Fix checkbox getting out of sync sync with dynamic

restaumatic / purescript-specular

A Reflex-Dom inspired UI library for PureScript

MIT License

131 stars 10 forks source link

Fix checkbox getting out of sync sync with dynamic #41

Closed kfigiela closed 5 years ago

kfigiela commented 5 years ago

Checkbox are ignoring value provided as an attribute (via dynamic) as soon as they are touched by the user. This becomes an issue when we want to change checkbox state externally (without user interaction). This patch should solve the issue.

kfigiela commented 5 years ago

Implemented both suggestions. I'm surprised that we didn't found this bug earlier. Looks like we rebuild larger portion of the DOM with dynamic in existing codebase.

zyla commented 5 years ago

@kfigiela Thanks, the tests look great.