search

resthub / resthub-backbone-stack

RESThub Backbone.js stack
http://resthub.org/docs/backbone/
Other
56 stars 26 forks source link

Ongoing work on issue #89 : Update to Backbone 0.9.10 #100

Closed sdeleuze closed 11 years ago

sdeleuze commented 11 years ago

Still some work to do in order to remove dispose(), see https://github.com/documentcloud/backbone/pull/1461#issuecomment-8674653 for more details

loicfrering commented 11 years ago

I think that tests/backbone-events.js can now be safely removed, it does not make sense anymore.

sdeleuze commented 11 years ago

Updated

sdeleuze commented 11 years ago

@loicfrering and @bmeurant, please review my last changes about using stopListening() instead of dispose()

loicfrering commented 11 years ago

:+1:

sdeleuze commented 11 years ago

Baptiste is not available this afternoon, I need these changes to be integrated so I merge this PR. I will make additional changes later if Baptiste find some issues

johanpoirier commented 11 years ago

Did you test the stack on IE7 & IE8 ?

sdeleuze commented 11 years ago

No, if somebody could (re)check that everything is fine before I release 2.0-rc1, it would be great !

johanpoirier commented 11 years ago

I will check.

johanpoirier commented 11 years ago

It's ok except when you activate Dev Tools on IE8. We should check that together.

sdeleuze commented 11 years ago

Didn't succeed to fix Function apply error on IE, @loicfrering could you help us to fix that ?

loicfrering commented 11 years ago

Sure, let's have a look together tomorrow as I don't have any IE at hand right now.