fix OAuth2Client

[bclozel]

@ncarlier found some bugs in our OAuth2 client implementation.

• The OAuth2Config bean does not hold OAuth2 credentials
• The retrieveAccessToken method does not get the right credentials (refactoring problem probably)
• spring-security-oauth has been released on central, so we can add it back to the stack
• and uncomment oauth tests

[sdeleuze]

OMG, they finally released it !!!

[bclozel]

@sdeleuze Sigh. It seems the token is not getting properly serialized by spring-security-oauth2, although the responsible class looks good to me.

Got the following token in debug, which looks like the actual OAuth2Token class:

{"value":"adf83c57-830d-4861-b057-d9a6722b4f60",
"expiration":1353448198023,
"tokenType":"bearer",
"refreshToken":null,
"scope":[],
"additionalInformation":{},
"expired":false,
"expiresIn":1}

Why is this token not getting properly serialized? Is there a conflict somewhere with their jackson dependency?

[bclozel]

Here's a more detailed comment about this issue.

spring-security-oauth 1.0.0.RELEASE depends on:

  <groupId>org.codehaus.jackson</groupId>
  <artifactId>jackson-mapper-asl</artifactId>

So that the OAuth2AccessToken class can have a custom serializer OAuth2AccessTokenSerializer.

RESThub depends on:

  <groupId>com.fasterxml.jackson.core</groupId>
  <artifactId>jackson-*</artifactId>

So I think the objectmapper we're using is not picking up the org.codehaus.jackson.map.annotate.JsonSerialize annotation (thus not using the custom serializer); and we get this exception:

com.fasterxml.jackson.databind.JsonMappingException:
Can not deserialize instance of java.lang.String out of START_ARRAY token

because the serialized token is the actual Java object (the error refers to the "scope" attribute being an array):

{"value":"adf83c57-830d-4861-b057-d9a6722b4f60",
"expiration":1353448198023,
"tokenType":"bearer",
"refreshToken":null,
"scope":[],
"additionalInformation":{},
"expired":false,
"expiresIn":1}

[bclozel]

Opened an issue on SpringSource JIRA - spring-security-oauth.

[bclozel]

Fixed PR #141 by commenting those tests (ugly, I know) to get those fixes into master.