search

resthub / resthub-spring-stack

RESThub Spring stack
http://resthub.org/spring-stack.html
Other
121 stars 66 forks source link

Bug with asynchttpclient using SSL with proxies #199

Closed matthieu-grigis closed 11 years ago

matthieu-grigis commented 11 years ago

The 1.7.16 asynchttpclient raise some problems with SLL and proxies, the request doesn't use relative URI, even if the boolean UseRelativeURIsWithSSLProxies is set to true in the config Builder. Indeed in the constructor of AsyncHttpClientConfig, the attribute is passed but never set. To solve this issue you need to use 1.7.17 version and override AsyncHttpClientConfig constructor by adding this line : new line ->this.useRelativeURIsWithSSLProxies = useRelativeURIsWithSSLProxies;

you need also to override the function build from AsyncHttpClientConfig.Builder. public ClientConfig build() { new line -> return new ClientConfig

In attachment you will find my patch, to solve this issue : https://gist.github.com/matthieu-grigis/74013a5fa6e52f34317d

bclozel commented 11 years ago

Waiting for https://github.com/AsyncHttpClient/async-http-client/pull/330 to be resolved.

sdeleuze commented 11 years ago

Fixed, please test and make a feedback.