search

resthub / springmvc-router

Adds route mapping capacity to any "Spring MVC based" webapp. Uses playframework.org Router implementation.
http://resthub.github.com/springmvc-router/
Other
167 stars 63 forks source link

Unclear documentation on request parameters #47

Closed DCKcode closed 11 years ago

DCKcode commented 11 years ago

The readme states that:

Controllers can use Spring MVC annotations and conventions - only the @RequestParam annotation is useless.

What does this mean for request parameters? Do they get mapped automatically without the annotation? Or should they be obtained in a different way (from the HttpServletRequest)?

It would be great if it could be made clear how request parameters should be handled with this router.

bclozel commented 11 years ago

Oops. I think it´s a typo in the documentation. I meant @RequestMapping is useless with the router. @RequestParam works as usual.

Will fix this in the documentation.

Good catch. Thanks.

Le mercredi 17 avril 2013, Rick van Galen a écrit :

The readme states that:

Controllers can use Spring MVC annotations and conventions - only the @RequestParam annotation is useless.

What does this mean for request parameters? Do they get mapped automatically without the annotation? Or should they be obtained in a different way (from the HttpServletRequest)?

It would be great if it could be made clear how request parameters should be handled with this router.

— Reply to this email directly or view it on GitHubhttps://github.com/resthub/springmvc-router/issues/47 .

-- Brian

DCKcode commented 11 years ago

Ah, that makes sense. Thanks!

67726e commented 11 years ago

Just thought I'd let you know this typo still exists on the GitHub Pages page for the project.

bclozel commented 11 years ago

Fixed! Thanks a lot!