search

resthub / springmvc-router

Adds route mapping capacity to any "Spring MVC based" webapp. Uses playframework.org Router implementation.
http://resthub.github.com/springmvc-router/
Other
167 stars 63 forks source link

Undeclared dependency on commons-lang #52

Closed msiedlarek closed 10 years ago

msiedlarek commented 10 years ago

Something's not right with commons-lang dependency. There is this one import from commons-lang:

https://github.com/resthub/springmvc-router/blob/master/src/main/java/org/resthub/web/springmvc/router/Router.java#L14

But I couldn't find commons-lang in dependencies or even transitive dependencies of the project, and so couldn't Gradle, co I had to manually provide it in my environment. Am I missing something or is it a bug?

(commons-lang being legacy library and deprecated in favor of commons-lang3 is an issue on it's own)

bclozel commented 10 years ago

Could you tell me which version of spring are you using?

msiedlarek commented 10 years ago

1.1.1

bclozel commented 10 years ago

Sorry, I meant which version of "spring-framework" are you using?

msiedlarek commented 10 years ago

Oh, my bad. 3.2.4.RELEASE

bclozel commented 10 years ago

OK. BTW, PRs are welcomed so don't hesitate to send a couple for those issues!