search

resthub / springmvc-router

Adds route mapping capacity to any "Spring MVC based" webapp. Uses playframework.org Router implementation.
http://resthub.github.com/springmvc-router/
Other
167 stars 63 forks source link

RouterConfigurationSupport should extend DelegatingWebMvcConfiguration #54

Closed msiedlarek closed 10 years ago

msiedlarek commented 10 years ago

RouterConfigurationSupport should extend DelegatingWebMvcConfiguration instead of WebMvcConfigurationSupport to provide automatic detecting of WebMvcConfigurer beans, which is normally provided by @EnableWebMvc annotation. That way you don't lose anything by not using @EnableWebMvc.

bclozel commented 10 years ago

Hi @msiedlarek ! Thanks for all this valuable feedback.

There's a new version for you to test, 1.2-SNAPSHOT (if have to add oss.sonatype snapshot repo to test it, see the README.md). This version should fix issues #8 #52 #53 and #54

Let me know how it works for you and I'll release the 1.2 version.

msiedlarek commented 10 years ago

Thanks for your work! I'll check it out later today

bclozel commented 10 years ago

Should I consider this snapshot ready for release?

msiedlarek commented 10 years ago

Yeah, sorry for the delay. It's exactly what I wanted and it works just fine. Thanks!