restic / rest-server

Rest Server is a high performance HTTP server that implements restic's REST backend API.
BSD 2-Clause "Simplified" License
944 stars 140 forks source link

Build restic at container build time #145

Closed jinnko closed 3 years ago

jinnko commented 3 years ago

What is the purpose of this change? What does it change?

Using docker's multi-stage builds we can build the restic/rest-server within a golang build environment then create a container for use (without the build environment) in a second build stage.

The advantages are:

  1. Building the rest-server is predictable in a pristine environment each time.
  2. Container builds ensure we get the latest rest-server every time.

Was the change discussed in an issue or in the forum before?

Not yet - will create an issue now.

https://github.com/restic/rest-server/issues/146

Checklist

NOTE: I will go through this checklist as soon as possible to satisfy all the requirements.

jinnko commented 3 years ago

Is there anything further you'd like to see in this PR before it's good to go?