What is the purpose of this change? What does it change?
This change addresses an issue in which the value of the --prometheus-no-auth flag actually got applied to the value of --prometheus when reading in flags.
Was the change discussed in an issue or in the forum before?
Issue was introduced in #112 alongside the inital implementation for --prometheus-no-auth
[ ] I have added documentation for the changes (in the manual): See below
[ ] There's a new file in changelog/unreleased/ that describes the changes for our users (template here): Unsure if this is needed due to just fixing an implementation issue self contained in unreleased
[x] I have run gofmt on the code in all commits
[x] All commit messages are formatted in the same style as the other commits in the repo: Unsure, commit style inconsistent
[x] I'm done, this Pull Request is ready for review
wojas
commented
3 years ago
What is the purpose of this change? What does it change?
This change addresses an issue in which the value of the
--prometheus-no-authflag actually got applied to the value of--prometheuswhen reading in flags.Was the change discussed in an issue or in the forum before?
Issue was introduced in #112 alongside the inital implementation for
--prometheus-no-authChecklist
changelog/unreleased/that describes the changes for our users (template here): Unsure if this is needed due to just fixing an implementation issue self contained in unreleasedgofmton the code in all commits