Closed ph818 closed 1 year ago
LGTM. Could you add a changelog/unreleased/issue-209
too (see changelog/TEMPLATE
) and also the other similar files in changelog/unreleased/
? This then gets added as an entry to the CHANGELOG for new releases.
Thanks! Added the changelog file: https://github.com/restic/rest-server/pull/212
Hi,
Nearly there - a pull request should comprise a coherent set of changes. What I would do from here is:
git cherry-pick
to do that)Github will automatically notice that you pushed additional changes to the branch for this PR, and update this PR with the extra commit.
What is the purpose of this change? What does it change?
Include #MemoryHigh=bytes, since this is the preferred way to handle memory according to https://www.man7.org/linux/man-pages/man5/systemd.resource-control.5.html
Was the change discussed in an issue or in the forum before?
Just now, concurrently: https://github.com/restic/rest-server/issues/209 Closes #209
Checklist
changelog/unreleased/
that describes the changes for our users (template here)gofmt
on the code in all commitsHonestly this section has a lot I don't yet understand; i am hoping since my pull request is very small in an example file that I've done the right stuff. Hopefully this is helpful in some small way! Thanks for creating the software!