add MemoryHigh to systemd example

ph818 commented 1 year ago

What is the purpose of this change? What does it change?

Include #MemoryHigh=bytes, since this is the preferred way to handle memory according to https://www.man7.org/linux/man-pages/man5/systemd.resource-control.5.html

Was the change discussed in an issue or in the forum before?

Just now, concurrently: https://github.com/restic/rest-server/issues/209 Closes #209

Checklist

[x] I have enabled maintainer edits for this PR
[ ] I have added tests for all changes in this PR
[ ] I have added documentation for the changes (in the manual)
[x] There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
[ ] I have run gofmt on the code in all commits
[ ] All commit messages are formatted in the same style as the other commits in the repo
[x] I'm done, this Pull Request is ready for review

Honestly this section has a lot I don't yet understand; i am hoping since my pull request is very small in an example file that I've done the right stuff. Hopefully this is helpful in some small way! Thanks for creating the software!

tim-seoss commented 1 year ago

LGTM. Could you add a changelog/unreleased/issue-209 too (see changelog/TEMPLATE) and also the other similar files in changelog/unreleased/ ? This then gets added as an entry to the CHANGELOG for new releases.

ph818 commented 1 year ago

Thanks! Added the changelog file: https://github.com/restic/rest-server/pull/212

tim-seoss commented 1 year ago

Hi,

Nearly there - a pull request should comprise a coherent set of changes. What I would do from here is:

Close PR #212
Add the commit to the branch that you made for this PR (you can use git cherry-pick to do that)
Push to your remote.

Github will automatically notice that you pushed additional changes to the branch for this PR, and update this PR with the extra commit.

restic / rest-server