Closed meise closed 1 year ago
Thank you for looking into it.
Even with the added commits, version variable in cmd/rest-server/main.go is still hard coded to 0.11.0
and manual build leads to an incorrect version number with --version
.
Arghh, sorry for the oversight. Should be fixed by https://github.com/restic/rest-server/commit/e8a839673f2962a35f7203850f94a26cfc80aabf
Output of
rest-server --version
How did you run rest-server exactly?
rest-server --version
What backend/server/service did you use to store the repository?
no special backend
Expected behavior
Building tag
v0.12.0
should result inrest-server --version
outputrest-server version rest-server 0.12.0 compiled with foo on bar
.Actual behavior
Building tag
v0.12.0
results inrest-server --version
outputrest-server version rest-server 0.11.0 compiled with foo on bar
.Steps to reproduce the behavior
Build tag
v0.12.0
from source.Do you have any idea what may have caused this?
There is a hard coded version number in cmd/rest-server/main.go which is automatically replaced in the releaser pipeline. In tag
v0.12.0
the hard coded version was not increased.So the automatic releases are ok, but manual builds have the wrong version number.
Do you have an idea how to solve the issue?
Increase version number manually or replace hard coded version numbers in source code with some automatism.
Did rest-server help you today? Did it make you happy in any way?
It's great.