search

restify / clients

HttpClient, StringClient, and JsonClient extracted from restify
MIT License
57 stars 34 forks source link

Support for checkServerIdentity https option #105

Closed jkryl closed 6 years ago

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 84.218% when pulling 99eb4f6c574bb328cec138335de3d62ff26d0c53 on jkryl:master into 85374f87db9f4469de2605b6b15632b317cc12be on restify:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 84.218% when pulling 99eb4f6c574bb328cec138335de3d62ff26d0c53 on jkryl:master into 85374f87db9f4469de2605b6b15632b317cc12be on restify:master.

DonutEspresso commented 7 years ago

Thanks for the PR! Would you mind adding some tests to verify that this is working?

jkryl commented 7 years ago

sure, I will try to find some time next week and add those tests. thanks

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 84.483% when pulling 0ccb124317bc77eb93d3c67f4e7b898010b6e56e on jkryl:master into 85374f87db9f4469de2605b6b15632b317cc12be on restify:master.

jkryl commented 7 years ago

@DonutEspresso: done. I think PR is ready to be merged.

simonepri commented 7 years ago

@DonutEspresso what about the status of this PR? Can be merged?

DonutEspresso commented 7 years ago

Apologies for delay on this! I think this looks fine.

@retrohacker @yunong any concerns?

DonutEspresso commented 6 years ago

This has been rebased against master and merged in #155. Apologies for the delay. 😞 We'll get a new version out ASAP!