search

restify / clients

HttpClient, StringClient, and JsonClient extracted from restify
MIT License
57 stars 34 forks source link

new: append to base path if one exists #171

Closed DonutEspresso closed 6 years ago

DonutEspresso commented 6 years ago

Fixes #75

It's unclear that the existing code ever worked as intended since this.path was never set. It turns out that fixing this behavior is a breaking change, so I gated it behind an option.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 86.946% when pulling f9ff2b7cf15d2676b78a37e20c7c323a7d417827 on reuse-basepath into a3acb608284bd4b804d4e5ab5982118f151294f0 on master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 86.946% when pulling f9ff2b7cf15d2676b78a37e20c7c323a7d417827 on reuse-basepath into a3acb608284bd4b804d4e5ab5982118f151294f0 on master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 87.024% when pulling 26361a0d5541ea45ac8894c51664e3af5278959e on reuse-basepath into df707eace1380f5eaf2e1a31dfc3e0acfdb54c95 on master.

DonutEspresso commented 6 years ago

@misterdjules once more? Magically, this PR didn't break any of the tests we added in the other PR (!!).

DonutEspresso commented 6 years ago

FYI, node 10 is broken (known issue), so Travis will continue to fail for now.