restify / node-restify

The future of Node.js REST development

http://restify.com

MIT License

10.71k stars 984 forks source link

fix: destroyed async/await handler #1937

Open misyuari opened 1 year ago

misyuari commented 1 year ago

Pre-Submission Checklist

[x] Opened an issue discussing these changes before opening the PR
[x] Ran the linter and tests via make prepush
[x] Included comprehensive and convincing tests for changes

Issues

Closes:

Issue #1941

Changes

Fix unstopped chain-handler when response already destroyed.

gmahomarf commented 1 year ago

I'm not sure how this fixes #1935. The issue there is that one is no longer allowed to have async handlers which also call next, due to handler arity checks.

misyuari commented 1 year ago

I'm not sure how this fixes #1935. The issue there is that one is no longer allowed to have async handlers which also call next, due to handler arity checks.

oh that was my fault, looks like it's a different issue, I've created a new issue

misyuari commented 1 year ago

can you add tests?

done, test added