Open urmilparikh opened 1 year ago
Restify Version: 11.0.0 Node.js Version: 14.15.3
Routing should work irrespective of params length
Routing works for params length up to 100, gives ResourceNotFound error for any longer
let restify = require('restify'); let server = restify.createServer(); server.get('/test/:data', function(req, res, next) { res.end(`Length: ${req.params.data.length}`); return next(); }); server.listen(80);
Works: http://localhost/test/1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
http://localhost/test/1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
Generates ResourceNotFound error. http://localhost/test/12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901
http://localhost/test/12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901
It seems there's a limit of 100 for params, which changed I think from v6 --> v7 A config option to increase this limit will be very helpful.
No, but I can help test.
Restify Version: 11.0.0 Node.js Version: 14.15.3
Expected behaviour
Routing should work irrespective of params length
Actual behaviour
Routing works for params length up to 100, gives ResourceNotFound error for any longer
Repro case
Works:
http://localhost/test/1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
Generates ResourceNotFound error.
http://localhost/test/12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901
Cause
It seems there's a limit of 100 for params, which changed I think from v6 --> v7 A config option to increase this limit will be very helpful.
Are you willing and able to fix this?
No, but I can help test.