search

restlet / restlet-framework-java

The first REST API framework for Java
https://restlet.talend.com
646 stars 284 forks source link

Ensure current application not set when there is no previous current application. #1409

Closed thomasjtaylor closed 3 months ago

thomasjtaylor commented 5 months ago

Fixes issue #1317 in 2.4 - applies #1318 (merged in 2.3) to 2.4.

We have been running this patch with restlet 2.4.3 for the last 2 years.

thomasjtaylor commented 5 months ago

Closes #1317 (for branches 2.3, 2.4)

thboileau commented 4 months ago

Hi @thomasjtaylor , thanks a lot for your contribution

as a first-time contributor, do you mind to sign and return the Joint Copyright Assignment to jlouvel@gmail.com? https://restlet.talend.com/assets/contributions/Restlet-Joint_Copyright_Assignment-General.pdf

thboileau commented 3 months ago

hi @thomasjtaylor , I've provided a fix by taking into account the comment of Jérôme (and adding your unit test - thanks again) If you don't mind, we can close this PR.

thomasjtaylor commented 3 months ago

I can test it out to confirm it resolves our issue. FYI. @rmbrad is the author of the original PR.

thomasjtaylor commented 3 months ago

@thboileau We've been testing your merged fix for the past week and everything is working fine. Thanks