search

restorando / angular-pickadate

A simple and fluid inline datepicker for AngularJS with no extra dependencies.
MIT License
273 stars 91 forks source link

Fix scope bindings and track displayed month. #18

Closed colinbate closed 9 years ago

colinbate commented 10 years ago

This PR is built on top of my work in #17, but is separate from it, so let me know if you want it on its own.

I've made changes so the scope variables bound from the parent scope will be reflected in the calendar. This allows for changing min/max/disabled dates. I've also changed the default-date option into display-month and it is updated in the parent scope (assuming the expression is assignable). If you change the display-month it will re-render the calendar.

gschammah commented 10 years ago

Hi @colinbate, thanks for all your contributions!

I still had no chance to see in detail your last PR. I am writing a test suite for this library and I would like to have that merged before merging any other pull requests, since the code is growing and also I would prefer to have the new features fully tested.

I think I will have the tests finished by this weekend (and also I hope I can take a look to your PRs by that time).

Thanks!

colinbate commented 10 years ago

@gschammah, no problem, that makes sense to me. I saw your other branch, so I figured that might be the case. Once you are happy with your setup, I don't mind writing tests for the stuff I did (assuming you are interested in pulling it).

gschammah commented 10 years ago

Hi @colinbate, sorry for getting back to you so late! Finally the library is tested and integrated with travis-ci. You will need to rebase your PR with master

jlambert121 commented 10 years ago

@colinbate this PR addresses something I was looking to fix. Any chance you could rebase it so it can be merged?

gschammah commented 9 years ago

Hi @colinbate

Now master has already this functionality. If you change minDate, maxDate, disabledDates, and weekStartsOn, the calendar will re render.

Thanks for your PR anyway!