search

restorando / angular-pickadate

A simple and fluid inline datepicker for AngularJS with no extra dependencies.
MIT License
273 stars 91 forks source link

Various Changes #31

Closed DrogoNevets closed 9 years ago

DrogoNevets commented 9 years ago

Updated to work with our system for you, requires my date-shim to work now (downside) but passes around actual date objects not strings into ngModel attribute (plus) and also allows for min/max date to be updated by the app and passes it through to the directive (plus)

DrogoNevets commented 9 years ago

need to add copyright to dateshim back later today

gschammah commented 9 years ago

Hi @DrogoNevets

Unfortunately I don't plan to add any dependencies to the library. Thanks anyway for your PR.

Gabriel

DrogoNevets commented 9 years ago

That's fair enough, but you may want to make it pass around Date Objects rather than string to the ngModel as this is good practice and also in most developers cases, expected behaviour.

The dependency allows for suger to be added to the Date object

like a toMidnight() method, which you may find useful as you do not handle times, one should set all times to the same known time (helps with testing, and comparison when using multiple date selectors

With your permission I will continue hosting my solution (with dependency) and continue working on it, and cite that it is based on work by you, but modified by myself

On 3 December 2014 at 15:15, Gabriel Schammah notifications@github.com wrote:

Hi @DrogoNevets https://github.com/DrogoNevets

Unfortunately I don't plan to add any dependencies to the library. Thanks anyway for your PR.

Gabriel

— Reply to this email directly or view it on GitHub https://github.com/restorando/angular-pickadate/pull/31#issuecomment-65423892 .

gschammah commented 9 years ago

Sure, feel free to work in your fork and keep improving it, and thanks for your feedback.