search

restorer / gloomy-dungeons-2

Gloomy Dungeons II - a continuation of old-school 3d-shooter.
http://mobile.zame-dev.org/gloomy-ii/
MIT License
93 stars 42 forks source link

Utility classes should not have public constructors #6

Closed AymanDF closed 8 years ago

AymanDF commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S1118 - “Utility classes should not have public constructors ”. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1118 Please let me know if you have any questions. Ayman Abdelghany.

restorer commented 8 years ago

Good for everything inside src/*. All other changed files are from 3rd party libraries.

I will think more about it, but currently I think that we shouldn't touch 3rd party libraries with non-critical changes.

Especially for holoeverywhere - this library is heavily based on reflection, and I'm not sure that these changes is 100% safe. It seems that all of changed classes are pure utility classes, but who knows what happen inside this library...

restorer commented 8 years ago

Partially merged for game code. About other code - we shouldn't touch 3rd party libraries with non-critical changes.