restraint-harness / restraint

Simple test harness which can be used with beaker
GNU General Public License v3.0
15 stars 26 forks source link

Add support of git protocol over https for fetch #321

Open pbabinca opened 3 weeks ago

pbabinca commented 3 weeks ago

Currently for URLs specified in <fetch /> restraint either:

For large repositories selective fetch has much better performance than download of the whole contents. The git protocol does not use encryption. To address requirements of the of data over-the-wire and not to make the fetching less performant I would like to request new feature - fetch URL over https using git protocol.


My understanding is that these code blocks determines the protocol to use fetch the archive:

and I'd suggest to use a new scheme: git+https for these URLs.

fetch_git.c would need to be extended to support, hopefully, small subset of https://github.com/git/git/blob/master/Documentation/gitprotocol-http.txt .

StykMartin commented 3 weeks ago

Support for git+https certainly sounds reasonable, we just need to make sure we can unpack properly, as this has been problematic for many attempts in the past.