update merge student bussiness logic into one file

restuwahyu13 / go-clean-architecture

Example go clean architecture folder pattern

127 stars 40 forks source link

update merge student bussiness logic into one file #1

Open fatchul opened 3 years ago

fatchul commented 3 years ago

Merged student domain into 1 service, because it will takes time to maintain if you separate per function per file. CMIIW

restuwahyu13 commented 3 years ago

Thanks for your pull request @fatchul01, but if you're change services functionality, this app cannot be running, because these handlers I need services functionality, please check your pull request again. Thank you

fatchul commented 3 years ago

updated, I think repository better not use plural naming, and why did you create many repositories instead of 1 repo, such as result and results

restuwahyu13 commented 3 years ago

Please check handler method before renewing the service, why I'm making repository into a small part, because if the project gets bigger, it'll be easy maintenance, and the name all depends on what each one wants