Not all commits are appearing as contributions

resume / resume.github.com

Resumes generated using the GitHub informations

https://resume.github.com

61.97k stars 1.36k forks source link

Not all commits are appearing as contributions #242

Closed rs2 closed 7 years ago

rs2 commented 7 years ago

E.g. https://github.com/pandas-dev/pandas/pull/12909

stuntguy3000 commented 7 years ago

Would/should closed contributions even count?

rs2 commented 7 years ago

@stuntguy3000 In what sense closed? :)

stuntguy3000 commented 7 years ago

This PR was not merged. If people use git in stupid ways like this, then unfournatly I don't think it can be too easy to detect that its your contribution.

rs2 commented 7 years ago

@stuntguy3000 You are right. Until now I thought that my commits were merged as a result of my PR.

stuntguy3000 commented 7 years ago

Indeed I am ;)