search

resurrecting-open-source-projects / scrot

SCReenshOT - command line screen capture utility
Other
512 stars 51 forks source link

remove VLA and imlib2's deprecated DATA32 type #198

Closed guijan closed 2 years ago

guijan commented 2 years ago

@N-R-K pointed out the deprecated type and revived interest in removing the only usage of a VLA in this project.

See the discussion after #193 was merged. I've tested taking a screenshot with and without a mouse cursor after applying this change, it worked fine.

daltomi commented 2 years ago

Hi again, is keeping the original location of the declarations important or is it okay if this PR changes them?

Hi,

Try reducing the scope of variables and using 'const-correctness' if possible.

daltomi commented 2 years ago

I made a few more small changes, I understand you wouldn't have a problem with this. I merge the branch in a few moments.