search

resurrecting-open-source-projects / scrot

SCReenshOT - command line screen capture utility
Other
512 stars 51 forks source link

fix libbsd feature test confusion #209

Closed guijan closed 1 year ago

guijan commented 1 year ago

Users expressed confusion when using the old "--without-libbsd" configure flag. Some assumed that it compiles scrot without libbsd, but it only made the build script error if libbsd is a dependency. This is useful to package maintainers: it gives them a yes/no answer on whether the library is a dependency on their system.

The old configure flag has been replaced by a more verbose "--enable-libbsd-feature-test".

See: https://github.com/resurrecting-open-source-projects/scrot/issues/208 https://github.com/resurrecting-open-source-projects/scrot/discussions/187

I've tested the yes/no paths using Alpine Linux and OpenBSD.

daltomi commented 1 year ago

Let's hope no one reads fast and doesn't see the -test at the end, because it also looks like you're enabling the libbsd library features: "If I enable libbsd it will be more secure"(or something like that) But if you prefer as it is we leave it like that.

eribertomota commented 1 year ago

I will wait for this change to release the 1.8.1 version.

daltomi commented 1 year ago

But if you prefer as it is we leave it like that.

Hi @guijan Please, if you can, confirm that you do not want to make changes to this PR, thank you.

guijan commented 1 year ago

Hi, yes, the PR is finished, I don't intend to change it.

daltomi commented 1 year ago

@eribertomota all ready to merge then, FYI this PR should close at #208 (Can we avoid libbsd?), thanks you.

eribertomota commented 1 year ago

@eribertomota all ready to merge then, FYI this PR should close at #208 (Can we avoid libbsd?), thanks you.

Thanks, @daltomi.