search

resurrecting-open-source-projects / scrot

SCReenshOT - command line screen capture utility
Other
511 stars 51 forks source link

optionsNameThumbnail: fix sign integer warning #259

Closed N-R-K closed 1 year ago

N-R-K commented 1 year ago

fixes a warning in the ubuntu CI

../../../src/options.c:542:47: warning: operand of ‘?:’ changes signedness from ‘long int’ to ‘size_t’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Wsign-compare]
  542 |     const size_t baseNameLength = extension ? extension-name : nameLength;
N-R-K commented 1 year ago

Was not enabling -Werror in the CI a deliberate choice or just an oversight?

guijan commented 1 year ago

Oversight.