search

resurrecting-open-source-projects / scrot

SCReenshOT - command line screen capture utility
Other
495 stars 49 forks source link

Add compression flag #293

Closed N-R-K closed 1 year ago

guijan commented 1 year ago

I just noticed the man pages say "between X and Y inclusive" in some places and "between X and Y" in others. I wonder which we should use?

https://github.com/resurrecting-open-source-projects/scrot/blob/fafced405301d1815025f1b6194aeca1d25173af/man/scrot.txt#L149

https://github.com/resurrecting-open-source-projects/scrot/blob/fafced405301d1815025f1b6194aeca1d25173af/man/scrot.txt#L56

N-R-K commented 1 year ago

That's something I've noticed too. One other option I thought about was using the mathametical notation for ranges. E.g [0, 10] to represent 0 to 10 inclusive.

But perhaps not everyone is familiar with such notation (though it should be very easy to figure it out just by trying --someflag LIMIT).

N-R-K commented 1 year ago

One more thing I realized, by setting a "compression" by default, it will break scripts where previously --quality 1 was used as a way to get highest compression of PNG images.

Maybe we can make it so that compression is only set if user explicitly asks for it. But that makes the interaction between quality and compression more complex. And it also prevents us from setting a "good default".

guijan commented 1 year ago

Although such scripts will no longer use the highest compression level, the program still behaves functionally the same, so I wouldn't do anything.