resurrecting-open-source-projects / scrot

SCReenshOT - command line screen capture utility
Other
511 stars 51 forks source link

scrotGrabMousePointer: error out on failure #317

Closed N-R-K closed 1 year ago

N-R-K commented 1 year ago

This turns the previous warnings into errors instead - since we couldn't accomplish what the user asked us to.

And while working on this, I also realized that the in-place mutation wouldn't violate strict aliasing and is legal. So remove the failure point created by malloc entirely.

ref: https://github.com/resurrecting-open-source-projects/scrot/issues/272

daltomi commented 1 year ago

Let's try not to place commits that do not go with what is indicated by the PR (I understand, I also did it sometimes)