replace dprintf() calls to fix the SmartOS port

resurrecting-open-source-projects / scrot

SCReenshOT - command line screen capture utility

Other

495 stars 49 forks source link

replace dprintf() calls to fix the SmartOS port #347

Closed guijan closed 1 year ago

guijan commented 1 year ago

I don't have access to a SmartOS system, so I haven't tested it on SmartOS. I did test it on OpenBSD.

Fixes #346.

N-R-K commented 1 year ago

I'm ok merging this. But dprintf has been standard since POSIX-2008, which is ~15 years old now. We should at the very least file a bug against Illumos about this and link the bug in the commit message.

Adding a comment (possibly with the Illumos bug link) is probably also a good idea to avoid someone accidentally using dprintf again (since we don't run Illumos CI, it won't be caught easily).

guijan commented 1 year ago

They have an 11 year old report of this: https://www.illumos.org/issues/1609

N-R-K commented 1 year ago

Also please add Fixes #346 into the commit message as well.