search

resyncgg / json-stream

A library to parse Newline Delimited JSON values from a byte stream
Apache License 2.0
4 stars 1 forks source link

add support for BYO Deserializer #2

Open tychoish opened 8 months ago

tychoish commented 8 months ago

I would kind of enjoy being able to use simd_json with this library, which I think could be achieved by permitting a BYO/dependency injectable Deserializer. I don't think this library would need to pick up the dependency, (but it could be feature flagged out or test-only) but it would offer a fair amount of flexibility.

Would you be interested in accepting a patch like this? I'm willing to do some (or more) of this work, if you like.

d0nutptr commented 8 months ago

I 100% would accept a patch to do this! Fantastic idea!

tychoish commented 8 months ago

I did a bit of poking to try and do this, and it definitely is not as easy as I initially expected, it would be, but I'm slightly newer to rust and my estimation game is of. My idea of "just put a deserializer object in a field on the struct" doesn't quite work as I wanted to. If there's a pattern or something that you'd like to see I'm definitely ears. I'll get back to this (probably) at some point regardless, but am definitely open to ideas.

d0nutptr commented 8 months ago

hey @tychoish !

I just wanted to let you know I see all of the PRs and comments coming into my email but I've just been a bit busy the last couple of days. Later this week I swear I'll get back to you :sweat_smile: . I hope that's okay! Thank you so much for taking an interest in this crate. I'll make sure to get it doing what you need, soon :tm: :)

tychoish commented 8 months ago

Thanks!

This is more of a "wouldn't it be nice if..." kind of thing, and the other stuff (captured in the PR) is actually the stuff I need/want. I totally understand busy. Look forward to hearing from you!