retaildevcrews / aks-secure-baseline-hack-template

Hands-on hack for learning AKS Secure Baseline

MIT License

1 stars 1 forks source link

Convert Git Origin URL To HTTPS from SSH For Flux #382

Closed alfredoihernandez closed 3 years ago

alfredoihernandez commented 3 years ago

Type of PR

[x] Documentation changes
[ ] Code changes
[ ] Test changes
[ ] CI-CD changes
[ ] GitHub Template changes

PR Checklist

[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] My code follows the code style of this project.
[X] I ran lint checks locally prior to submission.
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Purpose of PR

Hardcode Git Origin URL To HTTPS So SSH Cannot Be Set By Accident. Flux requires HTTPS

Does this introduce a breaking change

[ ] YES
[x] NO

Validation

[ ] Unit tests updated and ran successfully
[ ] Update documentation or issue referenced above

Issues Closed or Referenced

Closes #364

alfredoihernandez commented 3 years ago

Tested on a repo cloned with HTTPS (codespaces linux)

Tested on a repo cloned with SSH (mac os)