Issues with EVE7

[rete]

This issue page is meant for keeping track of all issues found in the ROOT experimental eve7 component. This issue will remain open until a "stable enough" version of eve7 will be provided.

---

1. Bugs

General

• [ ] Can't work without internet connexion. Can't load openui.
  • Should be fixed in root-project/root#4918. To be tested

Left menu

• [ ] Event scene arrow > not showing up after first event loaded. Fine with next event
• [x] No element tooltip poping-up on hover
  • Fixed in root-project/root#4918

Event scene

• [ ] Element tooltip is the element name but not the element title
  • Issue here: https://github.com/root-project/root/blob/4ab01509faa5722b1f4470654c4ccad836e5dd4b/ui5/eve7/controller/GL.controller.js#L767 ?
  • The tooltip has now totally vanished (no title or name used)
• [ ] REveTrack: setting line attribute to kDashed does not render as dashed on display. Any other value too. Always renders as plain line.
  • Should be fixed in root-project/root#4918. To be tested
• [x] Double-click anywhere resets the camera

---

2. Feature requests

General

• [ ] No interaction with geometry scene at all. A menu like the settings in the geom viewer would be nice
  • Will be added soon

Left menu

• [ ] After opening one event data collection and clicked on edit, a menu shows up down to edit the collection attributes (Rndr self, children, color, ...). Would be nice to add a close button to this menu
• [ ] Left menu context menu:
  • [ ] Render only selected
  • [ ] Render all except selected
  • [ ] Render all
  • [ ] Render none
• [x] Feature request: left-click on element, highlight element on scene if rendered
  • In principle the feature is there but not active
  • Fixed in root-project/root#4918.
• [x] In general the font size is too big. The mount of information shown in the left menu is not enough. The standard TEveManager had a nice vertical text spacing.
  • Dirty hack: CTRL+ - to reduce the font size
• [ ] The sub EveElement indent is not enough. For example, on the picture below, the indent before Particle 0 in the sub list of PandoraPFOs is not enough. It's a bit hard to see which element belongs to which parent element.
• [x] Add check box instead of "pen icon". Check/uncheck to render/un-render the element in the scene. Even maybe with a three state: all rendered, not rendered, partially rendered (children).
• [x] Add an element color in the tree view. For example I want particles to be in red, tracks in violet and clusters in blue in the tree view

Event scene

• [ ] Can't interact with drawn geometry in eve7 (picking, highlighting, etc ...)
• [ ] Context menu:
  • [ ] "Reveal in tree view": Shows the element in the left menu
• [ ] Select a point/object to center on for the camera

C++ interface

• [ ] The TEveBoxSet class was really useful and was lost in translation (maybe on purpose?). It allowed us for example to set different hit size and colors for a cluster having hits in the ECAL and the HCAL.
  • Will be added soon again
• [ ] I found the C++ interface a bit old style and confusing.
  • The memory management is not really clear. I see some RefCount methods dandling around, some pointers passed in methods that doesn't require a pointer to be passed, a (const) reference sometimes being more than enough.
  • A lot of ROOT old style inheritance from multiple classes make it really hard to address my implementation.
  • REveElement is a HUUUUUGE class like some other ones and the interface can be significantly reduced by using composition and "separation of concerns" principle.
  • Again separation would make the interfaces more clear. I found that the objects data (tracks, point sets, etc...) are not enough decoupled from the rest of the framework. A bit like TH1 and TCanvas with the Draw method

---

3. Nice features

Event scene

• Navigation with the mouse is nice

---

4. Questions / HOWTO

• [x] How to setup a fixed url for deployment ? Currently the port is changing all the time. Also a key is generated on the fly every time on startup and is part of the URL.
  • Solution here: https://root.cern/doc/master/classROOT_1_1Experimental_1_1RWebWindowsManager.html#a8eed54808b0d01e77af4238ae8a9a4f4
• [ ] How to higlight composite elements like PFOs, made of clusters and tracks, on the event scene ?

[rete]

[linev]

Here is first PR solving remaining "bugs"

https://github.com/root-project/root/pull/4918

It should be possible already now work without internet connection. We could make round of discussion that should be fixed/improved next

[rete]

Very nice ! This is very good news ! After merging I will have a try. Thanks Sergey

[linev]

I compress m.TreeStandardItem and provide checkbox and color indication.

Still in progress here: https://github.com/linev/root/tree/eve7_nextimpr

[linev]

Add following line to .rootrc to fix http port:

WebGui.HttpPort: 9222
WebGui.HttpMaxAge: 0

[linev]

Indentation in m.Tree cannot be easily changed. openui5 dynamically adjust it depending of number of levels. See https://experience.sap.com/fiori-design-web/tree/#responsiveness-and-adaptiveness Many other points should be improved/fixed with https://github.com/root-project/root/pull/4972

[rete]

Thank you for this comment.

For the indent, I guess we would have to live with it for the time being.

For the improvements, I actually pulled the ROOT changes in my docker image and had a quick test. It looks better indeed. There are more functionalities, in particular the context menu in the scene is really convinient.

But now I have a new issue: it seems that the event navigation is broken. When clicking on next or previous, there is no signal sent to the C++ server. It is either not send or not received, I will have to check in the javascript console and web server and make a proper debug.

I have pushed an updated docker image with the broken behavior under the name rete/lceve:nav-issue.

@alja Do you observe the same problem ?

[linev]

But now I have a new issue: it seems that the event navigation is broken. When clicking on next or previous, there is no signal sent to the C++ server.

I did not test it after I merge my and Matevz changes together. Should be elementary failure, which I will fix tomorrow-

[rete]

I suspected that it might be a piece of code broken on my side, but it is actually not it seems.

This is handler I have:

    /// Go to the next event
    nextEvent : function(oEvent) {
      console.log( "nextEvent" );
      this.mgr.SendMIR({
        "mir": "NextEvent()",
        "fElementId": this.eventMgr.fElementId,
        "class":      "lceve::EventNavigator"
      });
    }

The nextEvent message is actually printed in the console on button press but nothing happens. The issue is either in the sendMIR() function or on the server side.

[linev]

If code this way - it wrong. Now it should be like:

 this.mgr.SendMIR(
    "NextEvent()", this.eventMgr.fElementId, "lceve::EventNavigator"
  );

[rete]

Also doesn't work

[rete]

I've seen naming convention changing for fElementId. I don't remember in which PR. Can this be the problem ?

[linev]

I've seen naming convention changing for fElementId. I don't remember in which PR. Can this be the problem ?

Check actual value of this.eventMgr.fElementId variable. I did not change naming convention - only arguments of SendMIR

[rete]

This was the PR I was talking about:

https://github.com/root-project/root/pull/4810

but it's not the problem.

[linev]

Now offline features works again: https://linev.github.io/eve7/ Not perfect, but highlight, selection, rendering on/off, change color can be used without server. Of course, not intend to replace server, just to be able test client code. And of course, for demos.

[alja]

@rete Interface of SendMIR has changes. I have updated alja / EveWebApp repo to root masterbranch:

https://github.com/alja/EveWebApp/commit/f9a0b0b7fc4ffddb9ab5c0aa4fc3f75235134f22#diff-9a7e3525284176cea731b68e11192716

If you have your version of Summary view than you need to access editor with GedController: https://github.com/alja/EveWebApp/commit/88e619a6d5ed8bc2929061aaef8c8bff81a2c2d6#diff-1c056134d847a66e7cc485595352a849

[linev]

@rete I just submit PR to fix several small problems in @alja example. See here: https://github.com/alja/EveWebApp/pull/1