retejs / angular-plugin

https://retejs.org
MIT License
55 stars 36 forks source link

Nodes not visible when used in mat-tab control #4

Closed testermax closed 1 year ago

testermax commented 5 years ago

When I embeddeding the editor into a mat-tab control, the nodes are not visible after switching away and back to the tab which holds the editor. Only connection lines are visible.

Is this something that is possible to solve in the library?

`

Content 2 Content 3

`

Ni55aN commented 5 years ago

I think the mat-tab should have predefined sizes, as the NodeEditor container will adjust to the parent

testermax commented 5 years ago

Hi, forcing fixed height to each tab didnt seem to prevent the visible nodes to re-appear in the editor after I return to the tab they were placed in. As mentioned, only the connections re-appeared.

`

Content 2 Content 3
` ...didnt seem to solve the issue. Strange thing is that the minimap shows that the node is there, but when I click on the minimap, it dissapears from the minimap.
Ni55aN commented 5 years ago

@testermax what is the height of the .wrapper element? He doesn't seem to adjust to his parent

atalantus commented 5 years ago

I recreated the bug in my repo: https://github.com/atalantus/angular8-retejs-test-app/tree/mat-tab-group-bug

(Creating a stackblitz currently doesn't work with rete-angular-render-plugin? Maybe because of the failing AoT Build.)

atalantus commented 5 years ago

The .wrapper and the .node-editor element both seem to remain right-sized. However the child elements of the .node-editor have their size somehow changed to 0.

Ni55aN commented 5 years ago

@atalantus I don't see any related issues in your repo. Nodes are displayed correctly, right?

atalantus commented 5 years ago

After switching tabs I get this display bug in the latest Chrome version: 78.0.3904.108

Before switching tabs: 0

After switching to another tab and back: 1

atalantus commented 5 years ago

Same in firefox for me.

Make sure you are on the right branch. (mat-tab-group-bug) Master and other repositories rete related are just me trying to fix the AoT Compiler bug. ^^

rete-js[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.