search

retejs / context-menu-plugin

https://retejs.org
MIT License
11 stars 43 forks source link

Clicking on item with subitems causes type error #81

Closed Claybarn closed 6 months ago

Claybarn commented 6 months ago

Clicking on a menu item that has subitems (where the desired behavior is to have no action) causes the error:

props.data.handler is not a function

This error can be reproduced by clicking on the "extra" menu item found at the example here.

I imagine the solution is to add a empty function like: handler() {}

on this line. I forked this repo in the hopes of making a PR with this change, however I can't ensure it fixes the problem because the rete-cli emits a "Type generating failed" error when attempting to compile the context-menu-plugin.

Ni55aN commented 6 months ago

thanks, I'll take a look

duplicates https://github.com/retejs/context-menu-plugin/issues/79

rete-js[bot] commented 6 months ago

:tada: This issue has been resolved in version 2.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: