retejs / context-menu-plugin

https://retejs.org
MIT License
11 stars 43 forks source link

rete-cli won't compile context-menu-plugin #82

Closed Claybarn closed 6 months ago

Claybarn commented 6 months ago

The rete-cli won't compile this plugin, emitting a "Type generating failed" error. However, it does work on other plugins and the "master" branch.

Minimal steps to reproduce:

git clone https://github.com/retejs/context-menu-plugin cd context-menu-plugin npm i -g rete-cli rete build --config rete.config.ts

However, this works:

git checkout master rete build --config rete.config.ts

and this works:

git clone https://github.com/retejs/rete-kit cd rete-kit rete build --config rete.config.ts

Ni55aN commented 6 months ago

All plugin's dependencies should be installed:

git clone https://github.com/retejs/context-menu-plugin
cd context-menu-plugin
npm ci
npm run build

btw, master branch is for Rete.js v1

Claybarn commented 6 months ago

Ah yes that worked for me. Perhaps the documentation for rete-cli on the website should be updated?

Ni55aN commented 6 months ago

Building the project doesn't require installing dependencies, since in that example there are no dependencies. Since you forked an existing package that already has dependencies, you need to install them.

I guess it should be mentioned in Code contribution