search

retejs / context-menu-plugin

https://retejs.org
MIT License
11 stars 43 forks source link

Fix item with subitems crash when clicked #83

Closed Claybarn closed 6 months ago

Claybarn commented 6 months ago

Add dummy handler to item with subitems to prevent crashing. Fixes #81.

Claybarn commented 6 months ago

This solved the crashing issue but introduced a new one. It prevented zooming in and out on the graph. Will see if there is another solution.

Claybarn commented 6 months ago

Actually I take that back, the zooming issue happens if I compile the module from scratch without any changes at all.

Ni55aN commented 6 months ago

the zooming issue happens if I compile the module from scratch

https://github.com/retejs/react-plugin/blob/main/src/presets/context-menu/components/Menu.tsx#L39

this is expected behavior. Do you think it should passthrough context menu?

Claybarn commented 6 months ago

I collapsed the commits, let me know if anything else needs changing.

Ni55aN commented 6 months ago

please check CI and Commit linter workflows

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Ni55aN commented 6 months ago

commit message isn't conventional

Ni55aN commented 6 months ago

anyway, I can merge it into different branch and rebase

rete-js[bot] commented 6 months ago

:tada: This PR is included in version 2.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: