Soft wrap enable/disable

retext-project / retext

ReText: Simple but powerful editor for Markdown and reStructuredText

GNU General Public License v2.0

1.88k stars 196 forks source link

Closed holzkohlengrill closed 6 years ago

holzkohlengrill commented 6 years ago

Currently soft wrap is disabled in the settings (greyed out) as I undertand because it is still experimental.

When clicking on the text (instead of the greyed out tick box) I am still able to enable it.

Also wrapping does looks not as intended (though it might be that it is still not finished):

mitya57 commented 6 years ago

You are supposed to set “Draw vertical line at column” to non-zero value first, then you will be able to use soft wrap.

I will fix it.

holzkohlengrill commented 6 years ago

Possibly I get the idea wrong but shouldn't the soft wrap feature adapt on the window dimensions (width)?

mitya57 commented 6 years ago

ReText soft wraps at window borders by default. This feature is needed if you want to wrap earlier.

holzkohlengrill commented 6 years ago

I think this is more a usability issue:

When I enable soft wrap I expect that soft wrap is enabled and it will break at the window boarders.
However when it is disabled I expect that it will not wrap at all (currently it always wraps no matter if ticked or not)
Draw vertical line at column: after enabling and disabling the value remains (in my case it was the default value = 80).
- You might want to add another tick box to enable or disable the vertical line
- You can of course set it to 0 but that seems more like a hack (even if you would do virtually the same in the code)