retextjs / retext-contractions

plugin to check apostrophes in elided contractions
https://unifiedjs.com
MIT License
8 stars 3 forks source link

Apostrophe’s (pun intended) and numbers #7

Closed wooorm closed 5 years ago

wooorm commented 7 years ago

Currently, this plugin emits messages for two cases on benbalter.github.com

Warnings

Referring to a set of years

Digital talent–often in their 20's and 30's–need to see a clear path for uninhibited career development that's based on merit, not years spent, and that's beyond the confines of the digital department.

— (Emphasis mine, source: 2011-10-29-why-digital-talent-doesnt-want-to-work-at-your-company.md)

Referring to a title

Named one of the top 25 most influential people in government and technology and Fed 50's Disruptor of the Year

— (Emphasis mine, source: about.md)

Why

retext-contractions warns about these cases as they match a decade:

https://github.com/wooorm/retext-contractions/blob/5a4414770b341bb4d2bc9068aa3edd5b95fb6bb3/index.js#L34-L40

Reasoning goes that, “Generally apostrophes are used to indicate possession (‘Shirley’s dimple’) and contraction (‘can’t’),” and as this plugin is about contractions, and decades are contractions (the 19 part is omitted), a warning is given.

Both of these cases are not about contractions though. In my opinion, they’re not about contracting nor about plurals, so I think the apostrophe should be omitted (and some style guides suggest doing that)

Fix

...but that doesn’t fix anything. If those apostrophes were omitted in both cases, this plugin would still warn about 20s, 30s, and 50s.

What to do? Maybe this plugin should just drop the decade handling?

/cc @benbalter.