search

retextjs / retext-quotes

plugin to check quotes and apostrophes
https://unifiedjs.com
MIT License
11 stars 3 forks source link

Override not working? #6

Closed niftylettuce closed 7 years ago

niftylettuce commented 7 years ago

I am using preset-woorm and attempting to add this as the last entry to plugins, however it's not working. Any insight as to what's wrong?

      [ "retext-quotes", { "preferred": "straight" } ]
   95:60-95:61  warning  Expected a smart apostrophe: `’`, not `'`                apostrophe                  retext-quotes
wooorm commented 7 years ago

You need to provide your complete configuration for me to debug this, including version info!

niftylettuce commented 7 years ago

@wooorm config:

  "remarkConfig": {
    "settings": {
      "listItemIndent": "1"
    },
    "plugins": [
      "preset-wooorm",
      [
        "license",
        {
          "name": "Niftylettuce LLC.",
          "url": "http://niftylettuce.com"
        }
      ],
      "usage",
      [
        "contributors",
        {
          "contributors": []
        }
      ],
      "heading-gap",
      [ "lint-list-item-indent", "space" ],
      [ "retext-quotes", { "preferred": "straight" } ]
    ]
  },

versions: latest

wooorm commented 7 years ago

retext-quotes is a retext plugin, not a remark plugin. It doesn’t work directly in remarkConfig.

To get your own prose preset, you must pass it like so: https://github.com/wooorm/remark-preset-wooorm/blob/c858a1af53dcceb3de4fcd2756eebadf9ed79c3a/index.js#L13.

Your own prose preset could use retext-preset-wooorm btw!

wooorm commented 7 years ago

Thanks for the detailed info btw! 👍