retextjs / retext

natural language processor powered by plugins part of the @unifiedjs collective
https://unifiedjs.com
MIT License
2.36k stars 93 forks source link

Onboarding retext-language-server #57

Closed ChristianMurphy closed 1 month ago

ChristianMurphy commented 5 years ago

Continuation of https://spectrum.chat/?t=16557712-7029-4718-a2bc-38453fdfb928 and https://github.com/unifiedjs/governance/issues/11 @aecepoglu is offering to contribute retext-language-server. https://github.com/unifiedjs/governance/blob/master/governance-grant.md

I think it could be a good fit for the organization, and a good starting point for additional language servers for other unified projects. Thoughts @retextjs/core?

wooorm commented 5 years ago

LGTM! 👍

aecepoglu commented 5 years ago

I'm @aecepoglu and I am offering to contribute retext-language-server to the retextJS organization :)

Murderlon commented 5 years ago

I think it could be a good fit for the organization, and a good starting point for additional language servers for other unified projects.

Agreed. I also like the idea of a language server engine :)

wooorm commented 5 years ago

Enough time has passed (72 hours) and there are no objections, so @ChristianMurphy and @aecepoglu, feel free to continue with the next steps (4 through 6) and close this.

Let me know if I can help.

aecepoglu commented 5 years ago

Understood. I will handle the rest.

ChristianMurphy commented 2 years ago

Friendly ping, what's the status of this?

aecepoglu commented 2 years ago

Friendly response, I have forgotten about it.

Whatever needs to be done to transfer ownership, I'm ready to do it though.

ChristianMurphy commented 2 years ago

@wooorm regarding

feel free to continue with the next steps (4 through 6) and close this.

the link appears to be dead now, I'm not seeing a governance grant page in https://github.com/unifiedjs/governance or https://github.com/unifiedjs/collective, do you happen to know where this documentation moved to?

wooorm commented 2 years ago

governance was renamed to collective, this was the last version of that file: https://github.com/unifiedjs/collective/blob/950ad05f8c0ddb956863d3704df4b8146aaefb24/governance-grant.md, which was superseded by the organization policy (https://github.com/unifiedjs/collective/pull/29). See https://github.com/unifiedjs/collective/blob/main/organizations.md#motion-to-grant-governance and https://github.com/unifiedjs/collective/blob/main/organizations.md#granting

remcohaszing commented 2 years ago

Based on https://github.com/unifiedjs/unified-language-server/pull/13 I think every CLI based on unified-args should be accompanied by a language server.

Since retext doesn’t have a CLI, I don’t think retext should have a language server at this time either. However, it makes perfect sense to me to provide both.

wooorm commented 1 month ago

Closing this for now folks, it’s been a while. Things can also be maintained fine outside of the retextjs org!

github-actions[bot] commented 1 month ago

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.