search

rethinkdb / horizon

Horizon is a realtime, open-source backend for JavaScript apps.
MIT License
6.78k stars 350 forks source link

SSL option for RethinkDB connection #680

Open danielmewes opened 8 years ago

danielmewes commented 8 years ago

https://github.com/rethinkdb/horizon/pull/507 added support for RethinkDB's user and password options, but didn't add a way for enabling SSL for the RethinkDB connection.

We'll need an option to pass the location of the RethinkDB SSL certificate to Horizon, and Horizon has to pass the certificate's file path to r.connect through the ssl option if specified.

This is required for connecting directly to Compose RethinkDB clusters for example.

geddski commented 8 years ago

+1

Linicks commented 8 years ago

+1 For me as well. Unfortunately, this became a non-starter for me because my company has a secure protocol only policy. Hopefully, this can be addressed soon, because I can see allot of promise in Horizon.

GeoffreyPlitt commented 8 years ago

+1 I thought 2.0 was going to support SSL?

danielmewes commented 8 years ago

We should put this into Horizon 2.1.0 (or maybe even still add it to 2.0.0 before we release the final version?)

GeoffreyPlitt commented 8 years ago

Cool!

b-d commented 8 years ago

This was a problem for me as well, it's a quick fix to add a rdb_cert option in the horizon() constructor and then add ssl: { ca: this._cert } to the r.connect() call in https://github.com/rethinkdb/horizon/blob/next/server/src/reql_connection.js

GeoffreyPlitt commented 8 years ago

Is there an ETA yet on Horizon+Compose compatibility?