rethinkdb / horizon

Horizon is a realtime, open-source backend for JavaScript apps.
MIT License
6.78k stars 349 forks source link

Consider moving packaging from webpack to rollup #754

Open deontologician opened 8 years ago

deontologician commented 8 years ago

Since we're in es6 (soon to also be typescript) it would be nice to take advantage of rollup's benefits in bundle size.

Right now it's not too feasible since we'd want rxjs to come along for the ride, and their add/operator/* modules aren't handled properly by rollup at the moment: https://github.com/ReactiveX/rxjs/issues/1671

Adding this to Proposed so we can consider it later

intellix commented 8 years ago

Webpack 2 has tree shaking, thoughts on that?

deontologician commented 8 years ago

I have webpack 2 working in my typescript branch, it's probably fine for the medium term. The way we use our libraries, tree shaking isn't a huge benefit. The bigger benefit of rollup is that it gets rid of the entire module loading system and puts everything into the same scope. It cuts down on import overhead which webpack 2 still doesn't do

On Tue, Aug 16, 2016, 01:02 Dominic Watson notifications@github.com wrote:

Webpack 2 has tree shaking, thoughts on that?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rethinkdb/horizon/issues/754#issuecomment-240030851, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAFVs6S9Yo5seXU1fpQjt9KplVNbdLpks5qgW6AgaJpZM4Jk_aW .

vramana commented 8 years ago

Webpack has plans to implement the rollup functionality. See https://github.com/webpack/webpack/issues/2873

deontologician commented 8 years ago

That would be really sweet if they did that. There's definitely a lot more of a community behind webpack

tvld commented 8 years ago

We integrate tightly using webpack and vue.js - good combo ;)