search

rethinkdb / horizon

Horizon is a realtime, open-source backend for JavaScript apps.
MIT License
6.78k stars 349 forks source link

Fix: move .babelrc to its own file. #823

Closed deontologician closed 3 years ago

deontologician commented 8 years ago

This breaks nothing, our .babelrc shouldn't go out with the distributed package.

One caveat is that if you're doing React Native development, and you have horizon checked out from git and npm linked into your node modules, you'll get the same error as before. (Because the babelrc will be back since it's not the distributed version, just the version from

Fixes #814 Fixes #798 Fixes #255

This change is Reviewable

dalanmiller commented 8 years ago

Apologies to all for these ridiculous reviews and comments.

hendrikswan commented 7 years ago

I still haven't managed to get this working. I went as far as to clone the repo, checking out this branch, publishing an npm package to ensure that it follows the same build process, then installing that npm package into my react native project.

I am getting a different issue, it's not happy with the "ws" package. I then installed the ws package directly into my project, but then I hit a wall with peer dependencies of "ws", specifically crypto.

This doesn't feel right.. Any help would be appreciated!

hendrikswan commented 7 years ago

Dang! My issue was due to porting some code that I wrote and ran in node directly to my React Native app. In Node, you need to add a global WebSocket variable to make it available to the horizon client code. And I copied that over to my RN app, not realizing that RN also provided a global WebSocket!!

Mine is working now.