search

rethinkdb / rethinkdb-example-nodejs-chat

A node.js chat application running on rethinkdb
203 stars 75 forks source link

Change db host/port to rethinkdb defaults #1

Closed mchail closed 11 years ago

mchail commented 11 years ago

Really cool example app! Thanks for putting it together. I tried running it after I got rethinkdb installed, and it worked until the app needed to hit the database, at which point it crashed. Took me a second to realize I needed to switch db settings in /lib to the defaults of rethinkdb. For an example app, seems like a good idea to adhere to the host/port settings rethinkdb has out of the box.

Hope this is helpful feedback!

coffeemug commented 11 years ago

Whoops, thanks! We were going to document and publish the example a bit later, didn't expect people to start playing with it until it shows up on rethinkdb.com/docs :)

mchail commented 11 years ago

Got it! I saw the Todo and Pastie apps on HN today and figured the rest were fair game :smiley:

al3xandru commented 11 years ago

Thanks @mchail. I'll commit a change that will allow specifying the host and ports through env variables and default to localhost and 28015, respectively.

coffeemug commented 11 years ago

@al3xandru -- FYI, I already merged @mchail's patch that fixes the defaults. Also, I thought the code already allows changes via environment variables?

coffeemug commented 11 years ago

Err, I was thinking of Sinatra example.

al3xandru commented 11 years ago

@coffeemug exactly. @mchail's patch was reverting the settings to using the defaults. I've pushed the change I've mentioned a bit earlier.