rethinkdb / rethinkdb-example-nodejs

137 stars 98 forks source link

a few more issues w/ example #12

Open ralyodio opened 9 years ago

ralyodio commented 9 years ago

var result = yield r.table('todos').get(todo.id).update(todo, {returnVals: true}).run(this._rdbConn);

getting this message:

return_vals renamed to return_changes in: r.table("test").get("d53419a8-7a4c-4a8c-ab0c-338a8c677170").update({id: "d53419a8-7a4c-4a8c-ab0c-338a8c677170", name: "Joe2a"}, {returnVals: true})

danielmewes commented 9 years ago

Thanks for reporting this @chovy .

As the error message says we renamed returnVals to returnChanges, and apparently forgot to update this example.

Pinging @deontologician

danielmewes commented 9 years ago

Never mind, I opened a pull request https://github.com/rethinkdb/rethinkdb-example-nodejs/pull/13