search

rethinkdb / rethinkdb-go

Go language driver for RethinkDB
Apache License 2.0
1.65k stars 180 forks source link

ChangeResponse, type field #463

Closed nonotest closed 5 years ago

nonotest commented 5 years ago

Hello,

thanks for the wonderful work..

Just came a cross the need to use IncludeTypes in a changefeed and noticed that the current ChangeReponse struct does not include the Type field. It is pretty trivial to add the new field so I was wondering if there is maybe an issue with doing so? if not happy to submit a pr with the small change..

thanks!

type ChangeResponse struct {
    NewValue interface{} `rethinkdb:"new_val,omitempty"`
    OldValue interface{} `rethinkdb:"old_val,omitempty"`
    State    string      `rethinkdb:"state,omitempty"`
    Error    string      `rethinkdb:"error,omitempty"`
    Type     string      `rethinkdb:"type,omitempty"` <--------
}
CMogilko commented 5 years ago

Hello @nonotest Yeah, field is missed, you are welcome to pr.

nonotest commented 5 years ago

ok here: https://github.com/rethinkdb/rethinkdb-go/pull/464 thanks!