search

rethinkdb / rethinkdb-go

Go language driver for RethinkDB
Apache License 2.0
1.65k stars 182 forks source link

Error in v3 test: Errorf format %q has arg out of wrong type #465

Closed eclipseo closed 5 years ago

eclipseo commented 5 years ago

v3.0.5 on Go 1.12.5 Fedora Rawhide x86_64:

Testing    in: /builddir/build/BUILD/rethinkdb-go-3.0.5/_build/src
         PATH: /builddir/build/BUILD/rethinkdb-go-3.0.5/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/rethinkdb-go-3.0.5/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags "-X gopkg.in/gorethink/gorethink.v3/version=3.0.5 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
      testing: gopkg.in/gorethink/gorethink.v3
gopkg.in/gorethink/gorethink.v3/encoding
# gopkg.in/gorethink/gorethink.v3/encoding
./decoder_test.go:435:3: Errorf format %q has arg out of wrong type *gopkg.in/gorethink/gorethink.v3/encoding.UnmarshalerPointer
FAIL    gopkg.in/gorethink/gorethink.v3/encoding [build failed]

Probably affects master to since that code hasn't change since 3.0.5

CMogilko commented 5 years ago

It's golang changed behaviour. In go1.8 (latest go for gorethink.v3) it wasn't an error. I recommend to update to v5, it has some major bug fixes.

eclipseo commented 5 years ago

Sadly github.com/theupdateframework/notary is still using v3 in their latest release.

CMogilko commented 5 years ago

It was already fixed in develop branch. I believe soon it will be merged to master, but it can be v6.