search

rethinkdb / rethinkdb-go

Go language driver for RethinkDB
Apache License 2.0
1.65k stars 180 forks source link

RFC: Update go dependencies, replace logrus with slog and fix some linter issues #508

Closed majst01 closed 2 weeks ago

majst01 commented 1 month ago

Reason for the change With recent go versions slog comes as a decent logging implementation slog use this instead of logrus. Also some of the most obvious linter issues found by golangci-lint have been fixed.

Also most typos found by https://github.com/crate-ci/typos have been fixed.

This is meant as a starting point for further renewal of this excellent library.

gabor-boros commented 1 month ago

I need a day or two but will definitely get back with a reciew

majst01 commented 1 month ago

I need a day or two but will definitely get back with a reciew

Sure, no worries, we should add a integration test target to the makefile afterwards that everyone is able to run them locally.

majst01 commented 2 weeks ago

Hi @gabor-boros,

no worries, i am not in a hurry :-)

I made all the changes found during your review (hopefully), if you decide to merge this PR we should try to make the the integration tests run in the CI WDYT ?

majst01 commented 2 weeks ago

@gabor-boros Thanks a lot