search

rethinkdb / rethinkdb-java

Official RethinkDB Java client
https://rethinkdb.com/api/java/
Apache License 2.0
21 stars 10 forks source link

Release with hotfixes #54

Closed NotJustAnna closed 4 years ago

NotJustAnna commented 4 years ago

Reason for the change Release a hotfix to partial sequences and adds shutdown reasons to the response pump, which should help debug a later issue.

Description Result.java code related to partial sequences was moved out to a inner class.

Code examples No code changes.

Checklist

References None.

NotJustAnna commented 4 years ago

I don't understand why the tests fails, to be honest. Running locally works just fine.

martinpaljak commented 4 years ago

FYI: there is still a hang with partials (the test that directly calls .toList() hang intermittently).

I'll deploy it to see what the exception with pumps is.

NotJustAnna commented 4 years ago

.toList() hanging? Lemme see. Did I break aggressive fetch mode?

martinpaljak commented 4 years ago

https://repo1.maven.org/maven2/com/rethinkdb/rethinkdb-driver/2.4.4/ <- that looks messy.

NotJustAnna commented 4 years ago

Lol what? That's really confusing.

NotJustAnna commented 4 years ago

Uhh.. I'll try solve this with Boros once we can. (cc @gabor-boros)

Something on our publish routine is publishing the old version binaries with the new ones.

gabor-boros commented 4 years ago

Hell. I guess it’s that I forgot to remove the previous versions before deploy. I’ll redeploy the affected versions tomorrow

gabor-boros commented 4 years ago

If that’s possible

martinpaljak commented 4 years ago

"mvn clean deploy" or whatever is the equivalent with gradle should be the standard procedure.