rethinkdb / rethinkdb-python

Python driver for RethinkDB
https://rethinkdb.com/api/python/
Apache License 2.0
64 stars 35 forks source link

Update net_asyncio.py #267

Closed dpineiden closed 11 months ago

dpineiden commented 2 years ago

Reason for the change If applicable, link the related issue/bug report or write down in few sentences the motivation.

Description A clear and concise description of what did you changed and why.

Code examples If applicable, add code examples to help explain your changes.

Checklist

References Anything else related to the change e.g. documentations, RFCs, etc.

At the python doc, a closing of async socket has that two lines:

self.streamwriter.close()
await self.streamwriter.wait_closed()

In my case, despite closing connections, those are not closing and the number of open cons are increasing (without second line)

dpineiden commented 2 years ago

https://docs.python.org/es/3/library/asyncio-stream.html

codeclimate[bot] commented 11 months ago

Code Climate has analyzed commit 975e22a3 and detected 0 issues on this pull request.

View more on Code Climate.

srh commented 11 months ago

Sorry about the needless notification -- I unclosed because I realized my issue or PR maintenance would step on the real maintainers' toes. And there is a legitimate wait_closed change...