search

rethinkdb / rethinkdb-python

Python driver for RethinkDB
https://rethinkdb.com/api/python/
Apache License 2.0
64 stars 34 forks source link

2.4.10 release #301

Closed srh closed 11 months ago

srh commented 1 year ago

With fixes for Python 3.10-3.12, this driver needs a 2.4.10 release.

lsabi commented 1 year ago

@srh The last but one point has been merged into the master codebase. For reference https://github.com/rethinkdb/rethinkdb-python/pull/303

The last point has been carried out on a separate branch a while ago from me. See https://github.com/rethinkdb/rethinkdb-python/tree/lsabi/commands. Since I started it, there have been some changes in the master branch, thus some adjustments shall be done. Furthermore, the commands were not complete and are probably missing something.

srh commented 1 year ago

@lsabi I was imprecise -- I meant the rethinkdb dump and rethinkdb restore commands. I tried them out and they worked. Also, they work by using the _import and _export modules that the import and export command line commands use directly.

lsabi commented 1 year ago

@srh no problem. Then everything is completed for now. I shall check my branch if it's worth keeping or not.

srh commented 1 year ago

My understanding is, that branch has stuff not in master that you wanted to develop. I'd like to pop off this small release because there are Python 3.10-3.12 users who can't use all features of the driver right now.

lsabi commented 1 year ago

The idea was to refactor the entire codebase in order to make more readable and support the latest python versions. Unfortunately, time has been against us and couldn't finish it before new versions/features were released.

I need to figure out how the building automation works. @gabor-boros can you help?

lsabi commented 1 year ago

@gabor-boros I think I do not have the permissions to self-review my own PRs. Can you review it?

fdemian commented 1 year ago

Hi, everyone. I'm using this driver as well and having problems with async support and it seems like this new release would solve them. Is there anything I can do to hep this issue move forward?

gabor-boros commented 11 months ago

Closing this PR as the new version is just released: https://pypi.org/project/rethinkdb/

srh commented 11 months ago

Thanks @gabor-boros ! I've added a v2.4.10 tag and given it a GitHub release page: https://github.com/rethinkdb/rethinkdb-python/releases/tag/v2.4.10

gabor-boros commented 11 months ago

Oh, I forgot to push the tag. Anyway, thanks @srh!